Failing to create variables in euler1d.py by Gene0315 · Pull Request #1 · Gene0315/modmesh

Gene0315 · 2024-06-30T15:23:34Z

Following the issue solvcon#361
The PR sets the plotting points as an array 'pt_plot'. And then, it changes the points shown on the figure from coord[::2] to coord[self.st.svr.pt_plot].

However, there is something wrong in this code. It failed to create the variable 'svr.pt_plot' in 'modmesh/modmesh/onedim/euler1d.py'.

yungyuc · 2024-07-01T00:06:36Z

Please paste the complete traceback with the error

Gene0315 · 2024-07-02T05:52:35Z

Please paste the complete traceback with the error

I ran the python files in VSCODE and got the traceback below.

Traceback (most recent call last):
  File "/Users/genelin/modmesh/modmesh/onedim/euler1d.py", line 14, in <module>
    from .._modmesh import onedim as _impl  # noqa: F401
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: attempted relative import with no known parent package

yungyuc · 2024-07-02T05:59:33Z

What is the command you run? If you (cd /Users/genelin/modmesh/modmesh/onedim/; python3 euler1d.py), it's wrong. You need to make modmesh searchable in your path, and modmesh.onedim.euler1d cannot be executed as a script.

Gene0315 · 2024-07-02T09:04:45Z

What is the command you run? If you (cd /Users/genelin/modmesh/modmesh/onedim/; python3 euler1d.py), it's wrong. You need to make modmesh searchable in your path, and modmesh.onedim.euler1d cannot be executed as a script.

Sorry, I think I ran the modmesh.onedim.euler1d directly.

Gene0315 · 2024-07-02T09:11:04Z

In order to run the project correctly, I added a new file startu.py to execute the viewer. I ran it in VSCODE, and pressed the button 'Euler solver' like the picture below.

However, It failed to run the code and the messages are

bash-3.2$ /Users/genelin/devenv/flavors/new/usr/bin/python3 /Users/genelin/modmesh/startup.py
AttributeError: '_modmesh.onedim.Euler1DCore' object has no attribute 'pt_plot'

At:
  /Users/genelin/modmesh/modmesh/onedim/euler1d.py(41): init_solver
  /Users/genelin/modmesh/modmesh/onedim/euler1d.py(28): __init__
  /Users/genelin/modmesh/modmesh/onedim/euler1d.py(136): build_numerical
  /Users/genelin/modmesh/modmesh/app/euler1d.py(486): init_solver
  /Users/genelin/modmesh/modmesh/app/euler1d.py(496): set_solver_config
  /Users/genelin/modmesh/modmesh/app/euler1d.py(470): __init__
  /Users/genelin/modmesh/modmesh/app/euler1d.py(883): load_app
  /Users/genelin/modmesh/modmesh/view.py(101): launch
  /Users/genelin/modmesh/startup.py(3): <module>

yungyuc

Where is your pybind11 wrapper?

yungyuc · 2024-07-02T09:28:28Z

startup.py

@@ -0,0 +1,3 @@
+import modmesh.view as mv


It is not necessary to use a file to run code like this. A one-liner python3 -c 'import modmesh.view as v ; v.launch()' would do it.

But I'm not sure which file is appropriate to add this code. Is there anything wrong to add the startup.py in modmesh?

You do not need to add the code in a file. That is a one-liner you type in command line.

Gene0315 · 2024-07-03T06:05:41Z

Where is your pybind11 wrapper?

It is at /Users/genelin/devenv/flavors/new/usr/lib/python3.11/site-packages/pybind11

yungyuc · 2024-07-04T00:16:51Z

Where is your pybind11 wrapper?

It is at /Users/genelin/devenv/flavors/new/usr/lib/python3.11/site-packages/pybind11

That is where you install pybind11, not the wrapper. Wrapper is a class and the associated wrapping code like:

        (*this)
            .def_property_readonly(
                "coord",
                [](wrapped_type & self)
                { return to_ndarray(self.coord()); })
            .def_property_readonly(
                "cfl",
                [](wrapped_type & self)
                { return to_ndarray(self.cfl()); })
            .def_property_readonly(
                "so0",
                [](wrapped_type & self)
                { return to_ndarray(self.so0()); })
            .def_property_readonly(
                "so1",
                [](wrapped_type & self)
                { return to_ndarray(self.so1()); });

Gene0315 · 2024-07-06T06:27:47Z

Where is your pybind11 wrapper?

It is at /Users/genelin/devenv/flavors/new/usr/lib/python3.11/site-packages/pybind11

That is where you install pybind11, not the wrapper. Wrapper is a class and the associated wrapping code like:

        (*this)
            .def_property_readonly(
                "coord",
                [](wrapped_type & self)
                { return to_ndarray(self.coord()); })
            .def_property_readonly(
                "cfl",
                [](wrapped_type & self)
                { return to_ndarray(self.cfl()); })
            .def_property_readonly(
                "so0",
                [](wrapped_type & self)
                { return to_ndarray(self.so0()); })
            .def_property_readonly(
                "so1",
                [](wrapped_type & self)
                { return to_ndarray(self.so1()); });

The wrap wrap_onedim.cpp is at /Users/genelin/modmesh/cpp/modmesh/onedim/pymod.

yungyuc · 2024-07-06T06:37:12Z

The wrap wrap_onedim.cpp is at /Users/genelin/modmesh/cpp/modmesh/onedim/pymod.

Please provide a link to a file in your repository, not to your local path.

yungyuc · 2024-07-06T06:37:37Z

You can also add in-line annotation in this PR.

Gene0315 · 2024-07-06T08:52:40Z

The wrap wrap_onedim.cpp is at /Users/genelin/modmesh/cpp/modmesh/onedim/pymod.

Please provide a link to a file in your repository, not to your local path.

The link to the wrap_onedim.cpp is here

yungyuc

@Gene0315 your comment in #1 (comment) was not clear enough. Please see how the inline annotation in this review comment makes discussions more accurate.

Please try to resolve the testing failures shown in CI (e.g., https://github.com/Gene0315/modmesh/actions/runs/9817249358/job/27108402762?pr=1).

yungyuc · 2024-07-06T11:43:29Z

cpp/modmesh/onedim/pymod/wrap_onedim.cpp

                { return to_ndarray(self.gamma()); });

        (*this)
+            .def_property_readonly(


An inline annotation can be added like this.

Gene0315 · 2024-07-15T02:51:23Z

@Gene0315 your comment in #1 (comment) was not clear enough. Please see how the inline annotation in this review comment makes discussions more accurate.

Please try to resolve the testing failures shown in CI (e.g., https://github.com/Gene0315/modmesh/actions/runs/9817249358/job/27108402762?pr=1).

@yungyuc sorry, I don't know what is resolving the testing failure mentioned above. Does it mean that I have to execute the code by terminal with command

make cmakeclean
make buildext viewer VERBOSE=1 
./build/dev311/cpp/binary/viewer/viewer.app/Contents/MacOS/viewer

or how can I do it?

yungyuc · 2024-07-16T22:38:09Z

@Gene0315 your comment in #1 (comment) was not clear enough. Please see how the inline annotation in this review comment makes discussions more accurate.
Please try to resolve the testing failures shown in CI (e.g., https://github.com/Gene0315/modmesh/actions/runs/9817249358/job/27108402762?pr=1).

@yungyuc sorry, I don't know what is resolving the testing failure mentioned above. Does it mean that I have to execute the code by terminal with command
make cmakeclean
make buildext viewer VERBOSE=1 
./build/dev311/cpp/binary/viewer/viewer.app/Contents/MacOS/viewer
or how can I do it?

In that link, you can see Github Actions encountered a testing failure:

=================================== FAILURES ===================================
____________________ ShockTubeTC.test_field_with_numerical _____________________

self = <test_onedim_euler.ShockTubeTC testMethod=test_field_with_numerical>

    def test_field_with_numerical(self):
        self.st.build_numerical(xmin=-1, xmax=1, ncoord=21,
                                time_increment=0.05)
        self.st.build_field(t=0.0)
        self.assertIsInstance(self.st.svr, euler1d.Euler1DSolver)
>       self.assertEqual(len(self.st.coord), 11)
E       AssertionError: 9 != 11

tests/test_onedim_euler.py:110: AssertionError
=========================== short test summary info ============================
FAILED tests/test_onedim_euler.py::ShockTubeTC::test_field_with_numerical - AssertionError: 9 != 11
=================== 1 failed, 178 passed, 5 skipped in 4.31s ===================
make: *** [pytest] Error 1

vars_problem

c98054b

add_startup.py

7c918df

yungyuc suggested changes Jul 2, 2024

View reviewed changes

yungyuc reviewed Jul 2, 2024

View reviewed changes

add pt_plot to wrap_onedim

ea93b68

yungyuc suggested changes Jul 6, 2024

View reviewed changes

Gene0315 mentioned this pull request Jul 15, 2024

Adjust the boundary to improve the plotting solvcon/modmesh#335

Open

Gene0315 closed this May 10, 2025

Conversation

Gene0315 commented Jun 30, 2024

Uh oh!

yungyuc commented Jul 1, 2024

Uh oh!

Gene0315 commented Jul 2, 2024

Uh oh!

yungyuc commented Jul 2, 2024

Uh oh!

Gene0315 commented Jul 2, 2024

Uh oh!

Gene0315 commented Jul 2, 2024

Uh oh!

yungyuc left a comment

Choose a reason for hiding this comment

Uh oh!

yungyuc Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

Gene0315 Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

yungyuc Jul 4, 2024

Choose a reason for hiding this comment

Uh oh!

Gene0315 commented Jul 3, 2024

Uh oh!

yungyuc commented Jul 4, 2024

Uh oh!

Gene0315 commented Jul 6, 2024

Uh oh!

yungyuc commented Jul 6, 2024

Uh oh!

yungyuc commented Jul 6, 2024

Uh oh!

Gene0315 commented Jul 6, 2024

Uh oh!

yungyuc left a comment

Choose a reason for hiding this comment

Uh oh!

yungyuc Jul 6, 2024

Choose a reason for hiding this comment

Uh oh!

Gene0315 commented Jul 15, 2024

Uh oh!

yungyuc commented Jul 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants