Draft
Conversation
bamarler
requested changes
Feb 9, 2026
Collaborator
bamarler
left a comment
There was a problem hiding this comment.
Great work, this looks nice. Just please make sure that the checks pass.
Also, in the issue I said that we should use a zod plugin. Ideally Orval can generate that, but if you found that it's not possible we can discuss if it's necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note:
Generated output structure differs slightly from the original expectation.Orval generates schema-based type files with a shared index rather than a single flat generated.types.ts file.
Why this approach was kept: