Skip to content

Remove compatibility codes for Python<3.12 #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 1 commit into from
Dec 30, 2025
Merged

Remove compatibility codes for Python<3.12 #4322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pygmt/src/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,7 @@ def __init__(

Doesn't apply to the conventions ``"aki"``, ``"gcmt"``, and ``"partial"``.
"""
# TODO(Python>=3.12): Simplify to "convention in _FocalMechanismConventionCode".
if convention in _FocalMechanismConventionCode.__members__.values():
if convention in _FocalMechanismConventionCode:
# Convention is specified via the actual single-letter convention code.
self.code = _FocalMechanismConventionCode(convention)
# Parse the convention from the convention code name.
Expand Down
6 changes: 2 additions & 4 deletions pygmt/xarray/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,7 @@ def registration(self) -> GridRegistration:

@registration.setter
def registration(self, value: GridRegistration | int):
# TODO(Python>=3.12): Simplify to `if value not in GridRegistration`.
if value not in GridRegistration.__members__.values():
if value not in GridRegistration:
raise GMTValueError(
value, description="grid registration", choices=GridRegistration
)
Expand All @@ -225,8 +224,7 @@ def gtype(self) -> GridType:

@gtype.setter
def gtype(self, value: GridType | int):
# TODO(Python>=3.12): Simplify to `if value not in GridType`.
if value not in GridType.__members__.values():
if value not in GridType:
raise GMTValueError(
value, description="grid coordinate system type", choices=GridType
)
Expand Down
Loading