-
Notifications
You must be signed in to change notification settings - Fork 32
[AMDGPU] Add DPP row_shl fast path for shuffle_down reduction offsets #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZJLi2013
wants to merge
1
commit into
Genesis-Embodied-AI:main
Choose a base branch
from
ZJLi2013:amd-shuffle-down-dpp-fast-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
subgroup.shuffle_down(value, 1)reaches this AMDGPU fast path, lanes at 16-lane DPP row boundaries (for example lane 15) keep their own value instead of reading lane 16, even though the public API/codegen route allsubgroupShuffleDowncalls here and document lanei + offsetsemantics for every in-range lane. This may be acceptable for the current reduction tree's dead lanes, but it corrupts any directshuffle_downuse or future algorithm that needs boundary lanes; keep the generic helper for boundary-sensitive calls or make this optimization reduction-specific.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZJLi2013 This codex comment seems serious and structural to me.
I don't think we can corrupt the meaning of 'shuffle down'. It is a well known operation, and should behave unchanged, across all platforms.
One option that occurs to me is to create a new operation 'shift_left', and implement this across all GPU platforms (Metal, Vulkan, CUDA, AMD).
Thoughts?