Split callset into chunks for processing and add additional cli args #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalinigans
changed the title
mlathara
approved these changes
Jan 14, 2025
Member
mlathara
left a comment
mlathara
left a comment
There was a problem hiding this comment.
one question: otherwise lgtm
examples/genomicsdb_query
Outdated
| # Check if there is room for row_tuples to be parallelized | ||
| chunk_size = int(args.chunk_size) | ||
| if len(configs) < args.nproc and chunk_size > 1: | ||
| if row_tuples is None: |
Member
There was a problem hiding this comment.
Should we consider only doing the splitting by row tuples if all samples are being queried? I'm worried about the case where only a few random (but disjoint) samples are queried and that could lead to us creating a whole bunch of configs where each config is only querying a single sample
Member
Author
There was a problem hiding this comment.
Sure, you have a point and we could do the splitting only if all samples are being queried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly allow for multiprocessing of samples in callset based on
chunk sizeif no samples were specified togenomicsdb_query.Additionally add cli support to specify
chunk size, addbypass-intersecting-intervals-phaseand allow adryrunto see what may be processed without actually executing the query.