docs(components): rewrite Menu component documentation#3053
Merged
Conversation
Restructure the Menu docs page with clear sections for Summary, Anatomy, Behavior, Variants, Content Guidelines, Do's and Don'ts, Accessibility, and Related Components. Content Guidelines now includes Do/Don't tables for sentence case, verb-first labels, conciseness, context repetition, verb tense consistency, group labels, and destructive items. Made-with: Cursor
Deploying atlantis with
|
| Latest commit: |
1f759c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ee4b705.atlantis.pages.dev |
| Branch Preview URL: | https://menu-docs-edit.atlantis.pages.dev |
taylorvnoj
reviewed
May 7, 2026
Contributor
taylorvnoj
left a comment
taylorvnoj
left a comment
There was a problem hiding this comment.
@julia-wjw @George-W-M do either of you mind pulling in latest master since this branch is a little old.
Otherwise, just a few small comments
|
|
||
| It will have all the same elements as the standard version, and an additional | ||
| Overlay covering the non-Menu area. | ||
| - A menu item is selected |
Contributor
There was a problem hiding this comment.
Optional: unless it's a Menu.RadioGroup setup - but I'm not sure how specific we want to get here
Comment on lines
+47
to
+49
| Menu is positioned below the element that triggered it by default. It should | ||
| automatically reposition to appear on the left, right, above, or bottom of the | ||
| element that triggers it if the menu is cut off. |
Contributor
There was a problem hiding this comment.
Optional: Again maybe this is too specific for this doc section, but we can also control side & align (bottom start, top end, etc)
Comment on lines
+63
to
+69
| #### Menu Items | ||
|
|
||
| **1. Action:** Standard one-time actions such as navigating or triggering a | ||
| modal **2. SingleSelect:** Persistent choices like a filter of a view | ||
| preference. Use when choice persists and the user needs to see which option is | ||
| active. **3. Submenu:** Opens a nested menu of options on click and on hover. | ||
| Use when related actions are better surfaced one level deeper. |
Contributor
There was a problem hiding this comment.
This should probably include the Menu.RadioGroup/RadioItem
Comment on lines
+77
to
+79
| #### Group Label and Divider | ||
|
|
||
| Group labels and dividers can be used to separate and group menu items into |
Contributor
There was a problem hiding this comment.
Suggested change
| #### Group Label and Divider | |
| Group labels and dividers can be used to separate and group menu items into | |
| #### Group Label and Separator | |
| Group labels and separators can be used to separate and group menu items into |
maybe makes the "to separate" redundant, but we should avoid calling it a divider, when the component is called Menu.Separator
taylorvnoj
approved these changes
May 8, 2026
Contributor
taylorvnoj
left a comment
taylorvnoj
left a comment
There was a problem hiding this comment.
Thanks @julia-wjw for the follow up and @George-W-M for the original docs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
/components/Menu