chore: Add InputTime v2 Visual regression tests#3063
Draft
MichaelParadis wants to merge 3 commits into
Draft
Conversation
Deploying atlantis with
|
| Latest commit: |
53a1f3b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b9ab015e.atlantis.pages.dev |
| Branch Preview URL: | https://cleanup-add-inputtime-v2-vrt.atlantis.pages.dev |
MichaelParadis
commented
Apr 14, 2026
Contributor
Author
There was a problem hiding this comment.
Right Align and Center align has existing issue in Safari on both our V1 and V2 versions of InputTime. We likely didn't know about it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why Is This Changing?
We didn't actually have visual regression tests for InputTime V2. This Pr adds them in order to increase our visual regression coverage
What Is Changing?
Visual regression tests for Inputtime v2 are being added
Consumer Impact
Validation
Reviewer Notes
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.