feat(components): Remove v1 InputText#3075
Conversation
| ), | ||
| label: "Legacy V1 Docs", | ||
| // TODO: update this branch to the official v6 branch name once it's ready | ||
| url: "https://v6.atlantis.pages.dev/components/InputText?isLegacy=true", |
There was a problem hiding this comment.
TODO: update this link
| class="input" | ||
| id="«r0»" | ||
| type="text" | ||
| name="generatedName--«r0»" |
There was a problem hiding this comment.
This appears to be expected. type="text" is the default input type when not supplied. The v2 implementation just doesn't set it.
| @@ -10,7 +10,6 @@ import { | |||
| type Option, | |||
There was a problem hiding this comment.
TODO: we should remove v1 Autocomplete implementation and ship that before this InputText PR.
Then we can delete the changes here.
Deploying atlantis with
|
| Latest commit: |
e19b446
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2498daed.atlantis.pages.dev |
| Branch Preview URL: | https://job-145568-remove-v1-inputte.atlantis.pages.dev |
| : debouncedSearch | ||
| isControlled | ||
| ? (val: string) => searchComponent.props.onSearch(val) | ||
| : handleUncontrolledChange |
There was a problem hiding this comment.
Tested via a one-off story
Screen.Recording.2026-04-16.at.2.53.04.PM.mov
| .trim()} | ||
| </code> | ||
| </pre> | ||
| </Disclosure> |
There was a problem hiding this comment.
I don't understand why we had 2 code blocks... this disclosure seems redundant.
|
Published Pre-release for e19b446 with versions: To install the new version(s) for Web run: |
| @@ -1,5 +1,6 @@ | |||
| import React, { useRef, useState } from "react"; | |||
There was a problem hiding this comment.
Don't pay much attention to this file. All react-hook-form stuff (Form, useFormState) will be deleted in a subsequent PR.
| @@ -1,12 +1,45 @@ | |||
| import React, { useRef } from "react"; | |||
There was a problem hiding this comment.
Don't pay much attention to this file. All react-hook-form stuff (Form, useFormState) will be deleted in a subsequent PR.
| @@ -13,6 +13,7 @@ export default { | |||
| component: { | |||
There was a problem hiding this comment.
Don't pay much attention to this file. All react-hook-form stuff (Form, useFormState) will be deleted in a subsequent PR.
| @@ -3,6 +3,42 @@ import { InputText } from "@jobber/components/InputText"; | |||
| import { Content } from "@jobber/components/Content"; | |||
There was a problem hiding this comment.
Don't pay much attention to this file. All react-hook-form stuff (Form, useFormState) will be deleted in a subsequent PR.
When spreading props like {...inputProps}, it may contain unknown props such as `validations` which isn't valid on v2 InputText components. Typescript will not error for unknown props being spread.
By marking them as never, it helps catch cases where these props are implicitly spread, to ensure they get fixed accordingly.
1 participant
Why Is This Changing?
This PR deletes the V1 implementation of
InputText.DO NOT MERGE until after we prepare our next major v7 components release.
What Is Changing?
Consumer Impact
Validation
Reviewer Notes
Changes can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.