build: Upgrade to PNPM 11#3132
Draft
scotttjob wants to merge 1 commit into
Draft
Conversation
Deploying atlantis with
|
| Latest commit: |
57f6872
|
| Status: | 🚫 Build failed. |
jdeichert
reviewed
May 5, 2026
| corepack prepare pnpm@latest-10 --activate | ||
| pnpm config set store-dir ~/.pnpm-store | ||
| corepack prepare pnpm@11.0.5 --activate | ||
| echo 'export pnpm_config_store_dir="$PWD/.pnpm-store"' >> "$BASH_ENV" |
Contributor
There was a problem hiding this comment.
Why did the store-dir setup change? I didn't see that as a breaking change in their guide: https://pnpm.io/11.x/migration
jdeichert
reviewed
May 5, 2026
| docker run --rm -it \ | ||
| -v $(pwd):/atlantis \ | ||
| -v atlantis_pnpm_store:/pnpm-store/v10 \ | ||
| -v atlantis_pnpm_store_v11:/pnpm-store/v11 \ |
jdeichert
reviewed
May 5, 2026
| husky: set this to true or false | ||
| nx: set this to true or false | ||
|
|
||
| minimumReleaseAge: 7 |
Contributor
There was a problem hiding this comment.
This in minutes, so need to convert to 7 days https://pnpm.io/settings#minimumreleaseage
jdeichert
reviewed
May 5, 2026
|
|
||
| minimumReleaseAge: 7 | ||
| publicHoistPattern: | ||
| - run-node |
Contributor
There was a problem hiding this comment.
Unclear if we still need this publicHoistPattern. We didn't have it with v10 (unless pnpm read npmrc), so I'm not sure we still need it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why Is This Changing?
What Is Changing?
Consumer Impact
Validation
NOTE: We still need to add approval for build processes, I wanted us to spend a quick minute exploring the ones requesting access to run as a group (maybe on standup this morning).
Reviewer Notes
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.