Skip to content

feat(components): Remove v1 InputEmail#3140

Merged
MichaelParadis merged 9 commits into
masterfrom
JOB-145591/remove-input-email-v1
May 12, 2026
Merged

feat(components): Remove v1 InputEmail#3140
MichaelParadis merged 9 commits into
masterfrom
JOB-145591/remove-input-email-v1

Conversation

@MichaelParadis
Copy link
Copy Markdown
Contributor

@MichaelParadis MichaelParadis commented May 8, 2026

Why Is This Changing?

This PR deletes the V1 implementation of InputEmail.

What Is Changing?

  • Deleted V1 InputEmail
  • Renamed "InputEmailRebuilt" back to "InputEmail"
  • Replaced v1 stories/tests with v2 implementations
  • Updated any v1 usages to be v2

Note

Kept the legacy banner because we do have a plan to delete it as part of our component upgrade work

Consumer Impact

  • Impact: High
  • Action required: You will need to migrate to the new InputEmail implementation (v2)
  • Breaking change: Yes

⚠️ Although this is a breaking change, we've done a v7 major release for components and will be shipping all of these v1 removals in quick succession which will end up being minor versions on the v7 release line.

Validation

  • Main consumer has already had all v1s replaced with v2

Reviewer Notes

Changes can be tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

Update InputEmailRebuilt to include clearable tests from v1
@MichaelParadis MichaelParadis force-pushed the JOB-145591/remove-input-email-v1 branch from b1a0c15 to 43ff60c Compare May 8, 2026 16:05
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 8, 2026

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: a2831eb
Status: ✅  Deploy successful!
Preview URL: https://275c0c57.atlantis.pages.dev
Branch Preview URL: https://job-145591-remove-input-emai.atlantis.pages.dev

View logs

@MichaelParadis MichaelParadis marked this pull request as draft May 8, 2026 16:21
@MichaelParadis MichaelParadis removed the request for review from a team May 8, 2026 16:21
@MichaelParadis MichaelParadis changed the title feat(components): Remove v1 InputDate feat(components): Remove v1 InputEmail May 11, 2026
No longer generate a name when a name prop isn't provided in order to match our existing rebuilt inputs
@MichaelParadis MichaelParadis marked this pull request as ready for review May 11, 2026 16:54
@MichaelParadis MichaelParadis requested a review from a team May 11, 2026 17:41
@jdeichert jdeichert self-requested a review May 11, 2026 18:23
Copy link
Copy Markdown
Contributor

@jdeichert jdeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment thread packages/components/src/InputEmail/InputEmail.stories.tsx Outdated
@MichaelParadis MichaelParadis merged commit 652773f into master May 12, 2026
14 checks passed
@MichaelParadis MichaelParadis deleted the JOB-145591/remove-input-email-v1 branch May 12, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants