Skip to content

fix(components): Update Menu scroll#3141

Merged
taylorvnoj merged 2 commits intomasterfrom
TAYLOR/menu-scroll
May 8, 2026
Merged

fix(components): Update Menu scroll#3141
taylorvnoj merged 2 commits intomasterfrom
TAYLOR/menu-scroll

Conversation

@taylorvnoj
Copy link
Copy Markdown
Contributor

@taylorvnoj taylorvnoj commented May 8, 2026

Why Is This Changing?

]Long composable Menu dropdowns on desktop could grow past the viewport instead of becoming scrollable, which made large action lists difficult to use.

What Is Changing?

Composable desktop Menu dropdowns now get a default viewport-aware max height so long menus scroll instead of extending off-screen. Consumers can still set a custom desktop maxHeight on Menu.Content when they want a different length.

On mobile, Menu continues to use the existing bottom sheet sizing and scroll behavior. Size-related styles passed through Menu.Content no longer leak into the mobile shell.

A Storybook example was also added to show a long scrollable menu and a custom desktop length example.

Consumer Impact

  • Impact: Low
  • Action required: None
  • Breaking change: No

Validation

Reviewer Notes

  • whether the default desktop height cap feels correct for long menus
  • whether ignoring size-related Menu.Content styles in the mobile shell is the right boundary
  • whether the Storybook example communicates the intended desktop-only customization clearly

Changes can be
tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

@taylorvnoj taylorvnoj changed the title Taylor/menu scroll fix(components): Update Menu scroll May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Published Pre-release for 7785412 with versions:

  - @jobber/components@7.10.1-TAYLORmen-7785412.2+778541237

To install the new version(s) for Web run:

pnpm add @jobber/components@7.10.1-TAYLORmen-7785412.2+778541237

@taylorvnoj taylorvnoj marked this pull request as ready for review May 8, 2026 19:44
@taylorvnoj taylorvnoj requested a review from a team as a code owner May 8, 2026 19:44
@taylorvnoj taylorvnoj merged commit 92bf8af into master May 8, 2026
19 of 20 checks passed
@taylorvnoj taylorvnoj deleted the TAYLOR/menu-scroll branch May 8, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants