fix(components): Flatten Select css selectors#3144
Open
edison-cy-yang wants to merge 1 commit into
Open
Conversation
|
Published Pre-release for 821e607 with versions: To install the new version(s) for Web run: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why Is This Changing?
SyntaxError: [lightningcss minify] Invalid stateinvite:css-postagainst@jobber/components's builtSelectCSS, blocking consumers that use Vite + Lightning CSS for CSS minification..select::picker(select)::picker(select)indist/styles.css— a stacked pseudo-element shape Lightning CSS's parser bails on.cssMinify: "esbuild"as a workaround; this change removes the need for that fallback.What Is Changing?
Select.module.cssso the built output no longer contains the stacked::picker(select)::picker(select)chain.&::picker(select)block that already holds the transitions.Consumer Impact
cssMinify: "esbuild"workaround)Validation
@jobber/componentsand confirmedgrep '::picker(select)::picker(select)' packages/components/dist/styles.cssreturns 0 matches (it returned a match before).@supportsblock indist/styles.cssnow emits two clean rules:.select, .select::picker(select) { appearance: base-select }and a single-level.select::picker(select) { box-shadow; … transition; }.Reviewer Notes
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.