Skip to content

Cleanup Update to Node 24 + One New Feature#1

Merged
timoteialbu merged 8 commits intomainfrom
TIMOTEI/update-node-24
Mar 23, 2026
Merged

Cleanup Update to Node 24 + One New Feature#1
timoteialbu merged 8 commits intomainfrom
TIMOTEI/update-node-24

Conversation

@timoteialbu
Copy link
Copy Markdown

@timoteialbu timoteialbu commented Mar 23, 2026

  • Update to Node 24.
  • Update to ESM only (this was a result of updating the @actions packages, which are now ESM only, which trickled into broken tests etc).
  • Feat: As I was testing this in https://github.com/GetJobber/Jobber/pull/73753, I realized that if we run the same action twice, it always keeps the last one, meaning it overrides the comment it posts. So we have a "bug" in a sense because I am pretty sure we expected the action to post for each of the configs we ran on it, which is not currently the case. I debated using config-file as the differentiator, but landed on a new comment-key input instead (its simpler, backwards compatible, does not need to hash the path in case the path is weird etc)

QA

I've run this in https://github.com/GetJobber/Jobber/pull/73753 and you can see 2 comments being made.

@timoteialbu timoteialbu requested review from a team and jcw- March 23, 2026 18:13
@timoteialbu timoteialbu changed the title Cleanup Update to Node 24 Cleanup Update to Node 24 + One New Feature Mar 23, 2026
@timoteialbu timoteialbu merged commit 13c241f into main Mar 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants