[VID-1232] Add negotiation id for subscriber signaling offer-answer methods#1717
Merged
[VID-1232] Add negotiation id for subscriber signaling offer-answer methods#1717
Conversation
oliverlaz
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing a field to the offer on the websocket called "negotiationId", it will be an increasing counter, that basically should be echoed back in the answer (Acting like an ACK-kind of field). This is an effort to avoid unneeded/wrong negotiations, and to be able to safe re-send offers from SFU.
Idea is that:
This is a pre-step on what's needed for decorrelating ICE restart on websocket recovery. For example, if websocket is recovered and SFU sees signaling (offer/answer exchange) is not stable it can just re-send the current offer in case it was lost when the connection dropped.