Skip to content

fix: add company dashboard greeting fallback#73

Open
MolhamHamwi wants to merge 1 commit into
Ghbounty:mainfrom
MolhamHamwi:fix/company-dashboard-name-fallback
Open

fix: add company dashboard greeting fallback#73
MolhamHamwi wants to merge 1 commit into
Ghbounty:mainfrom
MolhamHamwi:fix/company-dashboard-name-fallback

Conversation

@MolhamHamwi
Copy link
Copy Markdown

Summary

  • Adds a safe fallback for the company dashboard greeting when the company name is missing or blank
  • Preserves the existing greeting when a company name is set

Verification

  • pnpm typecheck
  • pnpm test
  • pnpm --filter frontend exec eslint app/app/company/page.tsx

Closes #70

@MolhamHamwi MolhamHamwi requested a review from tomazzi14 as a code owner May 11, 2026 05:11
Copilot AI review requested due to automatic review settings May 11, 2026 05:11
@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

@MolhamHamwi is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a safe UI fallback for the company dashboard greeting so users without a populated company name no longer see an “undefined” placeholder in the header.

Changes:

  • Derives a companyName display value using company.name?.trim() with a "there" fallback.
  • Updates the dashboard hero title to render companyName instead of company.name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: dashboard greeting shows 'Hello, undefined' for users without a name

2 participants