fix: make landing footer year dynamic#74
Open
MolhamHamwi wants to merge 1 commit into
Open
Conversation
|
@MolhamHamwi is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend landing page footer to avoid a stale, hardcoded copyright year and refactors the X (Twitter) icon into a top-level component to satisfy linting.
Changes:
- Replace the hardcoded footer year with
new Date().getFullYear()rendered via acurrentYearvariable. - Hoist the inline
XIconout ofFooterinto a top-levelfunction XIcon(...)definition. - Refactor the
makeIconicon factory into a block-bodied function that returns an innerIconcomponent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new Date().getFullYear().Footerso the touched page passes targeted lint cleanly.Test Plan
pnpm --filter frontend exec eslint app/page.tsxpnpm --filter frontend testpnpm typecheckpnpm testCloses #69