Improve and publish docker images #770
Open
+167
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcpfuller
previously approved these changes
Nov 18, 2025
ColonelThirtyTwo
changed the title
ColonelThirtyTwo
changed the title
Rather than having the Django entrypoint script wait for postgres to start, use Docker's `depends_on` `service_healthy` condition. Slims down the entrypoint script.
Neither should be copied over - node_modules causes errors when copying and should be downloaded inside of the container, while pycache files are build artifacts.
Rather than mounting the metadata as a local volume, copy it over, so that it will be bundled with the image.
Faster access on Windows and shared with collab-server
Remove ports/expose from Hasura and PostgreSQL. Hasura can be accessed through Nginx, so there was no reason to expose it separately. Postgres is an internal service that doesn't need to be exposed.
Adds a `docker.yml` workflow that builds and, for tags, publishes docker images to the GitHub Container Registry.
ColonelThirtyTwo
force-pushed
the
docker-images
branch
from
3beecf9 to
f0de1e5
Compare
Heavily baed on Anthony Ledesma's PR (GhostManager#163), this builds the Python wheels in a separate stage, so that the published docker image does not have the packages for building or the source codes taking up space. The Django image has shrunk from roughly 2gb to 400mb.
ColonelThirtyTwo
dismissed
marcpfuller’s stale review
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize images and allow them to be ran standalone without needing to bind certain things from the GW source repo. Add a workflow to publish the images to GHCR.
See individual commits for descriptions of work.
Breaking change: This removes several exposed ports from the compose files. While most of these were redundant, users may have been using the PostgreSQL port for administration. The PostgreSQL database is still accessible via running commands in the Postgres Docker container, or by editing the compose files to re-expose the port.