Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Commit dac6316

Browse files
authored
empty view for labels and milestones (#1419)
1 parent db21d4d commit dac6316

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

Classes/Labels/LabelsViewController.swift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ final class LabelsViewController: UITableViewController {
2525
override func viewDidLoad() {
2626
super.viewDidLoad()
2727

28+
let emptyView = EmptyView()
29+
emptyView.label.text = NSLocalizedString("No labels found", comment: "")
30+
tableView.backgroundView = emptyView
31+
2832
tableView.refreshControl = feedRefresh.refreshControl
2933
feedRefresh.refreshControl.addTarget(self, action: #selector(LabelsViewController.onRefresh), for: .valueChanged)
3034

@@ -62,6 +66,8 @@ final class LabelsViewController: UITableViewController {
6266
var contentSize = tableView.contentSize
6367
contentSize.height = max(minContentHeight, contentSize.height)
6468
navigationController?.preferredContentSize = contentSize
69+
70+
tableView.backgroundView?.isHidden = labels.count > 0
6571
}
6672

6773
@IBAction func onDone() {

Classes/Milestones/MilestonesViewController.swift

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ final class MilestonesViewController: UITableViewController {
2525
override func viewDidLoad() {
2626
super.viewDidLoad()
2727

28+
let emptyView = EmptyView()
29+
emptyView.label.text = NSLocalizedString("No open milestones", comment: "")
30+
tableView.backgroundView = emptyView
31+
2832
tableView.refreshControl = feedRefresh.refreshControl
2933
feedRefresh.refreshControl.addTarget(self, action: #selector(LabelsViewController.onRefresh), for: .valueChanged)
3034

@@ -68,6 +72,7 @@ final class MilestonesViewController: UITableViewController {
6872
case .error:
6973
ToastManager.showGenericError()
7074
}
75+
self?.tableView.backgroundView?.isHidden = (self?.milestones.count ?? 0) > 0
7176
self?.feedRefresh.endRefreshing()
7277
}
7378
}

0 commit comments

Comments
 (0)