Skip to content

fix(lsp): make real-gopls integration test opt-in via env var #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PierrunoYT wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

fix(lsp): make real-gopls integration test opt-in via env var #691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d18337
fix(lsp): make real-gopls integration test opt-in via env var
PierrunoYT Jul 14, 2026
23390b0
fix(lsp): require ZERO_LSP_REAL_GOPLS_TEST=1 exactly for opt-in
PierrunoYT Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/lsp/real_gopls_manual_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,13 @@ import (

// TestManagerCheckRealGopls drives the exact path the self-correct LSP wiring
// uses (NewManager -> Check) against a REAL gopls and asserts a real diagnostic
// comes back. Skips when gopls is not installed. Temporary manual-verification
// test (the rest of the suite uses a fake server).
// comes back. Opt-in manual-verification test (the rest of the suite uses a
// fake server): the health, version, or cache state of a developer's globally
// installed gopls must not fail the default hermetic suite.
func TestManagerCheckRealGopls(t *testing.T) {
if os.Getenv("ZERO_LSP_REAL_GOPLS_TEST") != "1" {
t.Skip("set ZERO_LSP_REAL_GOPLS_TEST=1 to run the real gopls integration test")
}
if _, err := exec.LookPath("gopls"); err != nil {
t.Skip("gopls not on PATH; skipping real-server check")
}
Expand Down
Loading