Replace zip crate with rawzip in gix-archive

[Copilot]

Migrates gix-archive from the zip crate to rawzip for ZIP archive creation.

Changes

• Dependencies: Replaced zip = "6.0.0" with rawzip = "0.4.2" and added flate2 to zip feature (required for deflate compression)

• Archive writing (write.rs):

  • Use rawzip::ZipArchiveWriter with explicit flate2::DeflateEncoder for compression
  • Simplify timestamp handling: UtcDateTime::from_unix(seconds) instead of manual date/time component conversion
  • Ensure directory paths end with / (rawzip requirement)

• Tests (archive.rs):

  • Update to rawzip's reading API: ZipArchive::from_slice(), mode().is_symlink(), mode().value(), get_entry().data()
  • Adjust size expectations (rawzip produces ~7% larger archives than zip crate)

API differences

// Old (zip crate)
ar.start_file(path, options)?;
ar.add_directory(path, options)?;

// New (rawzip)
let (mut entry, config) = ar.new_file(path).start()?;
let encoder = flate2::write::DeflateEncoder::new(&mut entry, compression);
let mut writer = config.wrap(encoder);
// ... write data ...

ar.new_dir(&format!("{}/", path)).create()?;  // Must end with '/'

All existing tests pass. The zip crate and its transitive dependencies (arbitrary, derive_arbitrary) are removed from the dependency tree.

Original prompt

Replace the zip crate in gix-archive with https://github.com/nickbabcock/rawzip.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

This PR migrates gix-archive from the zip crate to rawzip for ZIP archive creation, removing transitive dependencies (arbitrary, derive_arbitrary) from the dependency tree.

Key changes:

• Replaces zip crate with rawzip and uses flate2 directly for deflate compression
• Updates archive writing to use rawzip's API with explicit compression handling via DeflateEncoder
• Adjusts tests to use rawzip's reading API and updates size expectations (~7% larger archives)

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File	Description
gix-archive/Cargo.toml	Replaces zip dependency with rawzip and adds flate2 to zip feature
Cargo.lock	Removes zip, arbitrary, and derive_arbitrary dependencies; adds rawzip
gix-archive/src/write.rs	Implements ZIP archive writing using rawzip API with explicit flate2 compression, proper UTF-8 error handling, and ensures directory paths end with /
gix-archive/tests/archive.rs	Updates tests to use rawzip's reading API and adjusts size threshold from 1280 to 1400 bytes

[Copilot]

The use bstr::ByteSlice; statement is repeated in all three match arms (lines 174, 203, and 224). For better maintainability, consider moving this import to the top of the function, just after line 168, so it's available for all match arms without repetition.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

The error message format string uses the Display implementation for BString, which may not be ideal for debugging UTF-8 issues. Consider using either the Debug formatting with {path:?} to show the raw bytes, or use String::from_utf8_lossy(path.as_ref()) in the error message to show what the path would look like with replacement characters, which would make it easier to identify the problematic characters.

Suggested change

	format!("Invalid UTF-8 in entry path: {path}"),
	format!("Invalid UTF-8 in entry path: {path:?}"),

[Copilot]

The error message would be more helpful if it included the symlink path and showed what the invalid target looks like. Consider including the symlink path in the error and using String::from_utf8_lossy to show the target with replacement characters for debugging.

Suggested change

	Error::Io(std::io::Error::new(
	std::io::ErrorKind::InvalidData,
	"Invalid UTF-8 in symlink target",
	let lossy_target = String::from_utf8_lossy(buf.as_slice());
	Error::Io(std::io::Error::new(
	std::io::ErrorKind::InvalidData,
	format!(
	"Invalid UTF-8 in symlink target for entry '{symlink_path}': {lossy_target}"
	),

[Byron]

Related to #2293 .