feat/validation-kit-events #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…examples - Updated references to `useNodeDefaultCABundle` to `useNodeDefaultCaBundle` for consistency across README.md, examples, and source files. - Ensured accurate documentation of the function to prevent confusion regarding its usage.
…socket attachment - Introduced a typed event emitter for validation events in HardenedHttpsValidationKit, allowing for better event management. - Updated the attachToSocket method to remove the callback, relying on events for success and error handling. - Improved the createConnection method in HardenedHttpsAgent to handle validation success through events. - Adjusted tests to reflect changes in event handling and socket attachment logic.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on August 23, 2025
Learn more in the Cursor dashboard.
|
|
||
| // Attach the validation kit to the socket | ||
| this.#kit.attachToSocket(socket); | ||
|
|
There was a problem hiding this comment.
Bug: Connection Callback Inconsistency
The createConnection method's callback is not reliably invoked. It's never called when ValidationKit emits a validation:error event, causing connections to hang. Additionally, the callback can be invoked multiple times by the validation:success and socket error handlers, leading to race conditions or post-validation errors.
…t validation - Updated the HardenedHttpsAgent to use a dedicated tlsSocket variable for improved clarity. - Introduced a new event 'hardened:validation:success' in the HardenedHttpsValidationKit to better manage validation success notifications. - Adjusted the error handling to emit 'hardened:validation:error' for consistency in event-driven architecture. - Modified tests to reflect the new event names and ensure proper validation flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useNodeDefaultCaBundlein documentation and examplesDescription
Related Issue
Type of Change
Checklist