Refactor: deduplicate code and improve maintainability#6
Merged
Conversation
- Extract shared constants, Shortcuts struct, home_dir(), and parse_script_content() into utils.rs - Deduplicate script search logic in input.rs via find_script_in_dir() helper - Deduplicate script listing and shortcut display in help.rs via write_scripts()/write_shortcuts() helpers - Change Command.execute() from &mut self to &self, eliminating unnecessary full struct clone - Replace is_some()/unwrap() with proper pattern matching in script.rs - Unify home directory resolution across all modules - Bump version to 2.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils.rsto eliminate duplication across modulesinput.rsand script listing inhelp.rsvia helper functionsCommand.execute()to take&selfinstead of&mut self, removing unnecessary struct cloningis_some()/unwrap()anti-pattern with proper pattern matchingTest plan