This repository was archived by the owner on Sep 16, 2022. It is now read-only.
storage_api: Avoid OverQuotaError from get_service_account_name#53
Open
evanj wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Open
storage_api: Avoid OverQuotaError from get_service_account_name#53evanj wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
evanj wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
Commit 10e7feb assigned app_identity.get_service_account_name to a local variable, outside of the if statement. This means it gets called every time this function is called, which makes an RPC on App Engine. During periods of high activity, this can exceed the per-minute API quota and raise OverQuotaError. To fix this, only call this if local_run() is True, which should only happen in development and never in App Engine production.
Contributor
Author
|
I just found a bug in this change, a year and a half later! This tweak makes this work with both unit tests and dev_appserver.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 10e7feb assigned app_identity.get_service_account_name to a local
variable, outside of the if statement. This means it gets called every time
this function is called, which makes an RPC on App Engine. During periods
of high activity, this can exceed the per-minute API quota and raise
OverQuotaError.
To fix this, only call this if local_run() is True, which should only
happen in development and never in App Engine production.