Skip to content

Refactor queries_grouped by hash and 2 additional optimization scripts from PR #471#517

Merged
danieldeleo merged 11 commits into
GoogleCloudPlatform:masterfrom
Andres-Ayala1:optimization-additions
Feb 17, 2026
Merged

Refactor queries_grouped by hash and 2 additional optimization scripts from PR #471#517
danieldeleo merged 11 commits into
GoogleCloudPlatform:masterfrom
Andres-Ayala1:optimization-additions

Conversation

@Andres-Ayala1

Copy link
Copy Markdown
Contributor

Ref PR: #471

Added the requested edits from this PR:

  • Consolidated duration percentile columns into queries_grouped_by_hash_org.sql and queries_grouped_by_hash_project.sql
    - Remove separate *_duration.sql files
  • Removed newline at end of bi_engine_mode_duration.sql

@Andres-Ayala1

Copy link
Copy Markdown
Contributor Author

@danieldeleo Seems bot did not auto-assign, please review and provide any additional changes needed when you have time :)

@afleisc afleisc self-requested a review February 9, 2026 16:03
@afleisc

afleisc commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

@danieldeleo I'm good with these changes if you'd like to take a final pass

Comment thread scripts/optimization/bi_engine_disabled_reasons.sql Outdated
Comment thread scripts/optimization/bi_engine_mode_duration.sql Outdated
Comment thread scripts/optimization/queries_grouped_by_hash_project.sql Outdated
Comment thread scripts/optimization/README.md Outdated
Comment thread scripts/optimization/README.md Outdated

@danieldeleo danieldeleo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments for changes, thanks!

@Andres-Ayala1

Copy link
Copy Markdown
Contributor Author

@afleisc @danieldeleo I have

  • updated the licenses
  • Removed ordering and limits from table creation scripts
  • added examples for new query analysis scripts
  • moved bi engine table scripts to query analysis section in README

Comment thread scripts/optimization/queries_grouped_by_script.sql Outdated

@danieldeleo danieldeleo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danieldeleo danieldeleo merged commit 56aa999 into GoogleCloudPlatform:master Feb 17, 2026
88 checks passed
Hackerpilot pushed a commit to Hackerpilot/bigquery-utils that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants