This repository was archived by the owner on Dec 12, 2024. It is now read-only.
upgrade to jetty-9.4.18 #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Contributor
Author
|
Ideally this would be built after GoogleCloudPlatform/openjdk-runtime#196 has been merged, built and released, as without that this runtime is failing on machines with 32GB of memory. |
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Contributor
Author
|
@donmccasland the smoke tests are now passing for me locally. I cleaned up some of the test classes to give better output, but the main change was to set the heap size so the test images actually start. edit: still failing on CI... trying a smaller heap size... but GoogleCloudPlatform/openjdk-runtime#196 is a better fix. |
Signed-off-by: Greg Wilkins <gregw@webtide.com>
donmccasland
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Greg Wilkins gregw@webtide.com