Skip to content

Enable OTel Logging for unmodified default pipelines#2239

Merged
quentinmit merged 13 commits intomasterfrom
quentin-builtin-otel
Mar 31, 2026
Merged

Enable OTel Logging for unmodified default pipelines#2239
quentinmit merged 13 commits intomasterfrom
quentin-builtin-otel

Conversation

@quentinmit
Copy link
Copy Markdown
Member

Description

Use OTel Logging for default_pipeline iff the default pipeline has not been modified and the user does not specify experimental_otel_logging: false.

Related issue

b/494017653

How has this been tested?

Integration tests and new confgenerator test

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@quentinmit quentinmit marked this pull request as ready for review March 20, 2026 22:10
Copy link
Copy Markdown
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but two questions

@quentinmit quentinmit force-pushed the quentin-builtin-otel branch from a539da8 to 53f6cf5 Compare March 31, 2026 19:33
@quentinmit quentinmit merged commit 7a50566 into master Mar 31, 2026
43 of 62 checks passed
@quentinmit quentinmit deleted the quentin-builtin-otel branch March 31, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants