fix: update agent self-metric to add error codec logic#2249
Open
rafaelwestphal wants to merge 5 commits intomasterfrom
Open
fix: update agent self-metric to add error codec logic#2249rafaelwestphal wants to merge 5 commits intomasterfrom
rafaelwestphal wants to merge 5 commits intomasterfrom
Conversation
XuechunHou
reviewed
Mar 31, 2026
| "Unauthenticated": "UNAUTHENTICATED", | ||
| } | ||
|
|
||
| var otelErrorTypeToStatus = map[string]string{ |
Contributor
There was a problem hiding this comment.
Can we merge this map with grpcCamelToSnake:
ops-agent/confgenerator/agentmetrics.go
Line 60 in 3073ea7
XuechunHou
reviewed
Mar 31, 2026
| "Unavailable": "UNAVAILABLE", | ||
| "DataLoss": "DATA_LOSS", | ||
| "Unauthenticated": "UNAUTHENTICATED", | ||
| "shutdown": "UNKNOWN", |
Contributor
There was a problem hiding this comment.
Looking at the upstream PR: https://screenshot.googleplex.com/7rTFJMhpNpGDgg9.
The error type can also be 'Shutdown' (capitalized) and 'Deadline_Exceeded' (Capitalized), and Canceled (capitalized, and misspelled).
Contributor
There was a problem hiding this comment.
We should also add an entry for cancelled in case upstream fixes the typo in the future.
XuechunHou
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapt Ops-Agent pipeline to leverage the error codes introduced in open-telemetry/opentelemetry-collector#14247
Related issue
b/468059325
How has this been tested?
Checklist: