[UTR Logging] Added gcp.use_legacy_mapping resource attribute to disable LogEntry.otlp field.#2250
Open
XuechunHou wants to merge 15 commits intomasterfrom
Open
[UTR Logging] Added gcp.use_legacy_mapping resource attribute to disable LogEntry.otlp field.#2250XuechunHou wants to merge 15 commits intomasterfrom
XuechunHou wants to merge 15 commits intomasterfrom
Conversation
| // all late entries flushed from a multiline parser after 1s. | ||
| "logs": { | ||
| otel.GCPProjectID("fake-project"), | ||
| otel.DisableOtlpRoundTrip(), |
Contributor
There was a problem hiding this comment.
Does it make sense to have a testcase that enables the OtlpRoundTrip scenarion?
Contributor
Author
There was a problem hiding this comment.
Currently, all logging receiver pipelines disable the OTLP round trip by default, including the otlp receiver. At least as part of the public preview, i dont think it's important to verify the 'on' scenario.
However, we do want to make sure that when otel.DisableOTLPRoundTrip() processor is set, LogEntry.otel field is unset by UTR. This can be done via an integration test and I already implemented it at: #2234
rafaelwestphal
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue b/491102815 was fixed recently. Added the gcp.use_legacy_mapping resource attribute to disable LogEntry.otlp population.
Related issue
b/491448977
How has this been tested?
Checklist: