Add --export.debug.log-match flag and gRPC request debug logging#320
Merged
Conversation
This adds the `--export.debug.log-match` flag to allow developers to specify Prometheus time series matchers. When set, any GCM time series matching these selectors will cause the exact filtered CreateTimeSeriesRequest protobuf to be logged at the DEBUG level prior to transmission over gRPC. TAG=agy CONV=6a59ce92-4dfe-45dc-bbec-57a860a8e424
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to debug gRPC requests by logging exact CreateTimeSeries requests that match specified Prometheus time series matchers. It adds a new command-line flag --export.debug.log-match to configure these matchers. The feedback points out a performance improvement opportunity: passing the protobuf message directly to the logger instead of eagerly calling .String(), which avoids unnecessary serialization overhead when debug logging is disabled.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
dashpole
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
--export.debug.log-matchflag to allow developers to specify Prometheus time series matchers. When set, any GCM time series matching these selectors will cause the exact filtered CreateTimeSeriesRequest protobuf to be logged at the DEBUG level prior to transmission over gRPC.TAG=agy
CONV=6a59ce92-4dfe-45dc-bbec-57a860a8e424