-
Notifications
You must be signed in to change notification settings - Fork 1.3k
move diff tool into its own directory #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Appu Goundan <appu@google.com>
Summary of ChangesHello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a structural refactoring by relocating the existing 'diff' tool into a dedicated subdirectory. This organizational change aims to streamline the process of integrating additional tools into the 'private/tools' path in the future, enhancing maintainability and modularity without altering the tool's core functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the repository by moving the diff tool into its own private/tools/diff directory. This is a good organizational change that will make it easier to add more tools in the future, as stated in the description. The changes correctly update all file paths in the diff.bash script to reflect the new location. The modifications are straightforward and correct, so I have no specific code suggestions.
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
|
🌳 🔄 Image Check |
this is to make it easier to add other tools into this path