-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make a runnable lifecycle tagger #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a new framework for automated lifecycle management of container images by integrating an existing bulk tagger with Bazel. The changes introduce specific Bazel rules and macros to enable the identification and tagging of older images, with the ultimate goal of deploying this functionality on Cloud Run as a scheduled task. This enhances the maintainability and organization of image repositories by ensuring timely application of lifecycle tags. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a runnable lifecycle tagger for container images using Bazel, which is a great addition for automating image management. The implementation is sound, but I've identified a few areas for improvement. My feedback focuses on enhancing code clarity, reducing redundancy, and improving the robustness of a shell command. Specifically, I've pointed out duplicated configuration values that should be centralized, and opportunities to simplify some of the Starlark code for better readability and maintainability.
7de6d22 to
b1e8a3b
Compare
This takes the bulk tagger and adds bazel wrappers around it. The intention is to query the system and run bulk tagger scripts on cloud run on a cron to tag any older images. Signed-off-by: Appu Goundan <appu@google.com>
b1e8a3b to
f840e56
Compare
|
🌳 🔄 Image Check |
This takes the bulk tagger and adds bazel wrappers around it. The intention is to query the system and run bulk tagger scripts on cloud run on a cron to tag any older images.