-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs(python3): clarify Python version compatibility and unsafe site-p… #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs(python3): clarify Python version compatibility and unsafe site-p… #1961
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @kaushalacts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the documentation for the python3 distroless image by adding crucial information about Python version compatibility and multi-stage build pitfalls. The new sections on versioning, recommended usage, and execution model are clear and will undoubtedly help many users avoid common errors. I have one suggestion to refine the 'Execution Model' section to prevent potential confusion regarding path usage in CMD, but overall this is an excellent and much-needed update.
python3/README.md
Outdated
| Distroless images do not include a shell or PATH resolution. Commands must use | ||
| absolute paths when invoking the Python interpreter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The statement Commands must use absolute paths when invoking the Python interpreter: is a bit strong and could be confusing. The examples/python3 directory shows a CMD with a relative path (["hello.py", "/etc"]) that works because of the base image's ENTRYPOINT and WORKDIR.
To make this clearer and avoid contradiction, I suggest rephrasing to explain why absolute paths are recommended, while acknowledging that other patterns can work. For example, you could mention the default ENTRYPOINT and then present the absolute path CMD as a more robust alternative:
Distroless images do not include a shell. The
python3image has a defaultENTRYPOINTofpython3, so you can provide a script as aCMD. However, for maximum clarity and to avoid ambiguity, we recommend using absolute paths for the interpreter in yourCMD:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the detailed review and the kind feedback — much appreciated.
Good catch on the wording in the Execution Model section. You’re absolutely right
that the python3 image’s default ENTRYPOINT allows providing a script via CMD,
as shown in the examples/python3 directory.
I agree that the current phrasing is too strong and could be confusing.
I’ll update the section to:
- Acknowledge the default ENTRYPOINT behavior
- Explain that absolute interpreter paths are a recommended, more explicit pattern,
rather than a strict requirement
I’ll push a small revision shortly to reflect this. Thanks again for the guidance.
Summary
This PR improves documentation for
gcr.io/distroless/python3by clarifyingPython version compatibility requirements and common pitfalls when using
multi-stage builds.
Several users (myself included) encounter confusing runtime failures when
copying Python site-packages built with a different Python minor version into
a distroless runtime image. These failures can appear as Python corruption
but are actually caused by ABI mismatches.
This change adds clear guidance to help users avoid this class of issues.
What this PR does
/usr/local/lib/pythonX.Yacross mismatched versionsWhat this PR does NOT do
Why this is useful
Modern Python workloads (FastAPI, data tooling, ML inference, etc.) often rely on
native extensions and newer Python versions. Without explicit documentation,
users can spend significant time debugging failures that are working as designed.
Clear documentation here should reduce support burden and improve user experience.
Fixes #1960