-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add cloud build config for lifecycle tagging #1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the lifecycle management of container images by integrating a new Cloud Build pipeline. It establishes a dedicated build job that prepares the execution environment with essential tools and then triggers a Bazel target to apply lifecycle tags, streamlining the process of updating or deprecating images based on predefined policies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a Cloud Build configuration for lifecycle tagging of container images. The changes include a new build script to set up the environment, a Cloud Build YAML file to define the build steps, and modifications to an existing tagging script.
My review focuses on improving the new build script's robustness and maintainability, and on simplifying the existing tagging script by removing redundant code. The changes in the Cloud Build YAML file look good, especially the use of a pinned image digest.
Key feedback points:
- In
.cloudbuild/lifecycle_tag.sh:- Enable
nounsetfor safer script execution. - Optimize
apt-getusage. - Improve consistency in tool installation by adding
bazeliskto thePATH.
- Enable
- In
private/tools/lifecycle/tag.sh:- Remove unnecessary
waitcommands afterreadarray.
- Remove unnecessary
| background_pid=$! | ||
| wait "$background_pid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
untrue, I want the set -e to kick in and exit the script
Signed-off-by: Appu Goundan <appu@google.com>
15fb28d to
bbf4a4a
Compare
|
🌳 🔄 Image Check |
The next and final step would be adding a scheduled cloud build trigger for this.