Skip to content

Conversation

@loosebazooka
Copy link
Member

@loosebazooka loosebazooka commented Jan 7, 2026

The next and final step would be adding a scheduled cloud build trigger for this.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the lifecycle management of container images by integrating a new Cloud Build pipeline. It establishes a dedicated build job that prepares the execution environment with essential tools and then triggers a Bazel target to apply lifecycle tags, streamlining the process of updating or deprecating images based on predefined policies.

Highlights

  • New Cloud Build Configuration: Introduced a new Cloud Build configuration file (.cloudbuild/lifecycle_tag.yaml) to automate the lifecycle tagging process for container images.
  • Lifecycle Tagging Script: Added a new shell script (.cloudbuild/lifecycle_tag.sh) responsible for setting up the necessary environment (installing gcrane, jq, and bazelisk) and executing the Bazel target for attaching lifecycle tags within the Cloud Build environment.
  • Script Execution Flow Improvements: Modified the existing private/tools/lifecycle/tag.sh script to include wait commands after readarray operations in both tag_update and tag_deprecate functions, ensuring proper command completion before proceeding.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

🌳 🔧 Config Check

This pull request has not modified the root BUILD

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Cloud Build configuration for lifecycle tagging of container images. The changes include a new build script to set up the environment, a Cloud Build YAML file to define the build steps, and modifications to an existing tagging script.

My review focuses on improving the new build script's robustness and maintainability, and on simplifying the existing tagging script by removing redundant code. The changes in the Cloud Build YAML file look good, especially the use of a pinned image digest.

Key feedback points:

  • In .cloudbuild/lifecycle_tag.sh:
    • Enable nounset for safer script execution.
    • Optimize apt-get usage.
    • Improve consistency in tool installation by adding bazelisk to the PATH.
  • In private/tools/lifecycle/tag.sh:
    • Remove unnecessary wait commands after readarray.

Comment on lines +46 to +47
background_pid=$!
wait "$background_pid"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The readarray command, when used with process substitution (< <(...)), already waits for the command inside the substitution to complete before proceeding. Therefore, explicitly capturing the PID and waiting for it is redundant and can be safely removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untrue, I want the set -e to kick in and exit the script

Signed-off-by: Appu Goundan <appu@google.com>
@loosebazooka loosebazooka merged commit b70878e into main Jan 7, 2026
13 checks passed
@loosebazooka loosebazooka deleted the lifecycle-tag branch January 7, 2026 18:13
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

🌳 🔄 Image Check
This pull request doesn't make any changes to the images. 👍
You can check the details in the report here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants