Open
Conversation
stu-k
suggested changes
Nov 16, 2017
stu-k
left a comment
stu-k
left a comment
There was a problem hiding this comment.
Map works, but your naming of the variables inside is misleading, filter is perfect, and forEach is a mess. I don't think this is your latest version of this project!
06week/higherOrder.js
Outdated
| const forEach = (inputArray, inputFunction) => { | ||
| const anotherArr = []; | ||
| for (let i = 0; i < inputArray.length; i++){ | ||
| anotherArr.push(inputFunction(inputArray[i])); |
There was a problem hiding this comment.
Pushing to an array that isn't returned, then logging the length. This isn't what forEach() does.
06week/higherOrder.js
Outdated
| // return anotherArr; | ||
| }; | ||
| const fullArray = [1, 2, 3]; | ||
| const inputFunction = i => fullArray.length; |
There was a problem hiding this comment.
Stop using .length everywhere, you don't need it.
| // } | ||
| const map = (arg1, arg2) => { | ||
| let nums = []; | ||
| arg1.forEach(index => nums.push(arg2(index))); |
There was a problem hiding this comment.
This map function works perfectly, but some of the things inside aren't named well. index isn't the index, it's the item, and the return array won't always be full of numbers, so nums doesn't make sense. But it works!
| if(inFun(inpt[i])) { | ||
| arr1.push(inpt[i]); | ||
| } | ||
| }return arr1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3