Conversation
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
DataTypes - nice job you need a few tweaks to your code. Also, in the future- a pull request should only have one assignment on it (every assignment gets it's own branch off of gh-pages)
01week/datatypes.js
Outdated
| function numStr(){ | ||
| var number = 27; | ||
| var a = number.toString(); | ||
| return a + a |
There was a problem hiding this comment.
This should also turn any number into a string, not just the number 27
01week/datatypes.js
Outdated
|
|
||
| function strNum(){ | ||
| var str = "27"; | ||
| var a = parseInt(str); |
There was a problem hiding this comment.
this should turn any string into a number, not just the string '27'
01week/datatypes.js
Outdated
| var d = 27; | ||
| var e = Math.sqrt(-1); | ||
| var f = "Im having Fun"; | ||
| return [typeof a, b, c, d, e, typeof f] |
There was a problem hiding this comment.
This should show the typeof of any argument that the function accepts. Don't hardcode variables
| const adding = (a, b) =>{ | ||
| // a = 7; | ||
| // b = 7; | ||
| return a + b |
There was a problem hiding this comment.
Nice, model all of your functions like this
01week/datatypes.js
Outdated
| var happiness = function(){ | ||
| var pizza = true; | ||
| var beer = true; | ||
| if(pizza && beer === true){ |
There was a problem hiding this comment.
This function hard codes two variables and if pizza evaluates to true and if beer is equal to the boolean true, it runs. I need a function to take into arguments and runs if they both evaluate to true.
01week/datatypes.js
Outdated
| //call the function | ||
|
|
||
|
|
||
| function kindaHappiness(){ |
There was a problem hiding this comment.
See comments on the happiness() function and apply.
01week/datatypes.js
Outdated
|
|
||
|
|
||
| function epicSadness(){ | ||
| var pizza = 1; |
There was a problem hiding this comment.
See comments on the happiness() function and apply.
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Jon, you're still off on the last three problems and your program construction. Go ahead and merge and we'll review in class.
3 participants
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3