Skip to content

Remove Uselss Navigation #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YoniKiriaty wants to merge 2 commits into
base: dis1
Choose a base branch
from
Open

Remove Uselss Navigation #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bfb13d
Yoni - stop crashing the metrics when bps is null
YoniKiriaty Apr 19, 2026
6e1553e
removed useless navigation options
YoniKiriaty Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/scouting/frontend/src/strategy/components/MetricsChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type { TeamData } from "@repo/scouting_types";
const NUMBER_OF_DIGITS = 2;
const Metric: FC<{
name: string;
value: number;
value?: number;
colors: string;
onClick?: () => void;
}> = ({ name, value, colors, onClick }) => (
Expand All @@ -19,7 +19,7 @@ const Metric: FC<{
{name}
</span>
<span className="text-3xl font-black">
{value.toFixed(NUMBER_OF_DIGITS)}
{value?.toFixed(NUMBER_OF_DIGITS)}
</span>
</div>
);
Expand Down
4 changes: 1 addition & 3 deletions apps/scouting/frontend/src/strategy/components/StrategyNavBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { NavLink, Outlet } from "react-router-dom";
import { LuTable, LuSwords } from "react-icons/lu";
import { AiOutlineTeam } from "react-icons/ai";
import type { IconType } from "react-icons/lib";
import { TiWeatherCloudy } from "react-icons/ti";

const NavigationElement: FC<NavigationElementProps> = ({
isActive,
Expand Down Expand Up @@ -34,8 +33,7 @@ interface NavigationOption {
const strategyNavigationOptions: NavigationOption[] = [
{ destination: "team", label: "Team", icon: AiOutlineTeam },
{ destination: "general", label: "General", icon: LuTable },
{ destination: "compare", label: "Compare", icon: LuSwords },
{ destination: "forecast", label: "Forecast", icon: TiWeatherCloudy },
{ destination: "tinder", label: "Tinder", icon: LuSwords },
];

interface NavigationElementProps {
Expand Down