Node system -> master#357
Draft
Nitay4 wants to merge 12 commits into
Draft
Conversation
github-actions
Bot
added
needs-robot-testing
A-SMALL-PR
needs-simulation-testing
labels
YHerm
reviewed
Oct 1, 2025
YHerm
reviewed
Oct 1, 2025
YHerm
reviewed
Oct 1, 2025
YHerm
reviewed
Oct 1, 2025
YHerm
reviewed
Oct 1, 2025
YHerm
reviewed
Oct 1, 2025
YHerm
reviewed
Oct 1, 2025
YHerm
reviewed
Oct 1, 2025
YHerm
reviewed
Oct 1, 2025
hillelv
reviewed
Oct 1, 2025
hillelv
left a comment
hillelv
left a comment
There was a problem hiding this comment.
ok I realized I can't do this CR without you explaining the code to me (which either means this is very bad code or this is a very complicated concept)
Comment on lines
+8
to
+9
| private double gCost; | ||
| private double hCost; |
Author
There was a problem hiding this comment.
those are the names in the algorithm, technically the h represents heuristic but i'm pretty sure that the g doesn't represent anything, i think it's better to leave it like that
|
|
||
| private RobotState[] neighbors; | ||
|
|
||
| static { |
There was a problem hiding this comment.
why is it assigned in a static block and not in a constructor?
Author
There was a problem hiding this comment.
because java is funny, i cant assign a state as a neighbor before its constructed
Comment on lines
+89
to
+90
| for (int i = 0; i < RobotState.values().length; i++) { | ||
| for (int j = 0; j < RobotState.values().length; j++) { |
Author
There was a problem hiding this comment.
i prefer it like that, if its critical to you i will change but i dont see why
| return hCost; | ||
| } | ||
|
|
||
| public double getFCost() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.