Set filter on inventory for pattern buffer#4869
Open
jurrejelle wants to merge 3 commits into
Open
Conversation
jurrejelle
added
type: bugfix
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #4821 by preventing external item insertion into the ME Pattern Buffer’s inherited ItemBus inventory (which is not exposed via the UI), avoiding situations where items become stuck/inaccessible and can be lost.
Changes:
- Disables all insertions into the part’s inherited bus inventory by applying an always-false item filter.
- Adds an explanatory inline comment describing why the filter is applied.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
github-actions
Bot
added
Tests: Failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
closes #4821
Implementation Details
We still create the inventory since it subclasses ItemBusPartMachine, we just make it inaccessable
AI Usage
How Was This Tested
Before:
After:
