[Balance] Swap Pyro Oven coil multiplier from post-OC to pre-OC#4918
Open
DilithiumThoride wants to merge 1 commit into
Open
[Balance] Swap Pyro Oven coil multiplier from post-OC to pre-OC#4918DilithiumThoride wants to merge 1 commit into
DilithiumThoride wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pyrolyse Oven has a recipe time multiplier that comes from the tier of Coils it's built with. However, this multiplier is applied after Overclock calculations, meaning that if the machine were overclocked high enough to reach 1-tick OCs and enter Subtick, the high tier coils would have no effect on its speed.
By swapping the apply order so that coil duration applies before OC, high tier coils at high power overclocks will still have an effect and will start producing subtick overclocks.
This is however a Balance Change. (Affects ZPM+)
as of 06/15, Ghosti has cleared the balance implications.
Implementation Details
The Pyro Oven is the only multiblock in service that uses a two-stage recipe modifier where both stages modify Duration in a way that impacts throughput. As such this is not a case that exists elsewhere and it was likely not caught for when Subtick Overclocking was considered.
AI Usage
Additional Information
This only actually matters at extremely high overclock tiers.
To quote @TechLord22 who did the math on this,
[...]
Tech notes that the Pyro Oven (on Nitrogen-Wood Tar) goes 1-tick at UEV. With 4x speed from Tritanium Coils, that drops 1-tick down to UV. However, with 16A Energy Hatches, 16A LuV = 1A UV, meaning 16A ZPM would be 1A UHV, which pushes the oven past the 1-tick point making this change relevant.