Move runtime model generators to their own package and rename the classes#4923
Open
screret wants to merge 3 commits into
Open
Move runtime model generators to their own package and rename the classes#4923screret wants to merge 3 commits into
screret wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Title. Moves them to a more appropriate package and renames them, as the current names are purely leftovers from LDLib renderers. I don't know why I didn't rename them back then, honestly.
AI Usage
Outcome
The classes' names reflect what they do. This should alleviate some confusion I've seen people have with them.
How Was This Tested
Just class renames, there isn't much to test.
Potential Compatibility Issues
Addons using these classes will have to fix their code, but that's already a given, so I don't see it as a major issue.