Skip to content

Final parts of machine refactor#4925

Draft
gustovafing wants to merge 15 commits into
mui2-refactorfrom
gus/more-trait-stuff
Draft

Final parts of machine refactor#4925
gustovafing wants to merge 15 commits into
mui2-refactorfrom
gus/more-trait-stuff

Conversation

@gustovafing

@gustovafing gustovafing commented Jun 12, 2026

Copy link
Copy Markdown
Member

What

Final parts of machine refactor

  • Removal of IHasCircuitSlot in favour of circuit slot trait
  • Removal of IHasBatterySlot in favour of battery slot trait
  • Changes and documentation to a lot of machine ctors
  • More stuff I need to document :3

This shouldn't be merged into mui, it targets mui for review purposes only.

# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/cover/CoverBehavior.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/trait/RecipeLogic.java
#	src/main/java/com/gregtechceu/gtceu/api/sync_system/SyncDataHolder.java
#	src/main/java/com/gregtechceu/gtceu/api/sync_system/data_transformers/ValueTransformer.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/electric/BlockBreakerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/electric/ItemCollectorMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/HPCAMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/ItemBusPartMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/steam/LargeBoilerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/steam/SteamMinerMachine.java
# Conflicts:
#	gradle/scripts/repositories.gradle
#	src/generated/resources/assets/gtceu/lang/en_ud.json
#	src/generated/resources/assets/gtceu/lang/en_us.json
#	src/main/java/com/gregtechceu/gtceu/api/cover/CoverBehavior.java
#	src/main/java/com/gregtechceu/gtceu/api/item/component/prospector/ProspectorMode.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTrait.java
#	src/main/java/com/gregtechceu/gtceu/api/registry/registrate/GTRegistrate.java
#	src/main/java/com/gregtechceu/gtceu/client/renderer/BlockHighlightRenderer.java
#	src/main/java/com/gregtechceu/gtceu/common/blockentity/CableBlockEntity.java
#	src/main/java/com/gregtechceu/gtceu/common/cover/ender/AbstractEnderLinkCover.java
#	src/main/java/com/gregtechceu/gtceu/common/item/behavior/MachineConfigCopyBehaviour.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/FusionReactorMachine.java
#	src/main/java/com/gregtechceu/gtceu/integration/embeddium/GTEmbeddiumCompat.java
#	src/main/java/com/gregtechceu/gtceu/integration/kjs/GregTechKubeJSPlugin.java
#	src/main/java/com/gregtechceu/gtceu/integration/map/ftbchunks/veins/ore/OreVeinIcon.java
#	src/main/java/com/gregtechceu/gtceu/integration/recipeviewer/jei/GTOreProcessingJeiCategory.java
#	src/main/java/com/gregtechceu/gtceu/integration/recipeviewer/rei/GTOreProcessingReiCategory.java
#	src/main/java/com/gregtechceu/gtceu/utils/GTStringUtils.java
@gustovafing gustovafing changed the title Gus/more trait stuff Final parts of machine refactor Jun 12, 2026
# Conflicts:
#	gradle/scripts/repositories.gradle
#	src/generated/resources/assets/gtceu/lang/en_ud.json
#	src/generated/resources/assets/gtceu/lang/en_us.json
#	src/main/java/com/gregtechceu/gtceu/client/renderer/BlockHighlightRenderer.java
#	src/main/java/com/gregtechceu/gtceu/common/cover/ender/AbstractEnderLinkCover.java
@github-actions github-actions Bot added the Tests: Failed Game Tests have failed on this PR label Jun 12, 2026
@jurrejelle jurrejelle added the Do Not Merge DO NOT MERGE THIS PR YET! label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge DO NOT MERGE THIS PR YET! Tests: Failed Game Tests have failed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants