Change some registries to use resource locations, and move some static maps to be registries#4936
Open
gustovafing wants to merge 9 commits into
Open
Change some registries to use resource locations, and move some static maps to be registries#4936gustovafing wants to merge 9 commits into
gustovafing wants to merge 9 commits into
Conversation
Contributor
|
I imagine this will be breaking to some packs, maybe add a line or two about it to v8.0.0.md? |
Contributor
oh you updated the methods to be the same 🤔 I think this should be fine in 90% of cases? thre are some packs that might still be referencing it directly but I'll leave it up to you if you wanna add docs for it |
Member
Author
|
All the api methods are same, I don't think we need a note about the removal of the static maps, etc since they aren't supposed to be accessed externally to begin with. |
screret
suggested changes
Jun 16, 2026
screret
left a comment
screret
left a comment
Contributor
There was a problem hiding this comment.
Are material icon types intentionally left as is?
Member
Author
|
Material icon types are weird, they don't actually store anything it's just a list of strings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switch tag prefixes, material icon sets and placeholders to be stored in registries.
Convert element registry to a resource location registry
Methods for getting/registering content which is now stored in a registry have been marked as deprecated.
Methods for registering using string keys will default to GT namespace
AI Usage
Potential Compatibility Issues