Skip to content

Fixed cover removal not syncing render state to clients #4937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dalizi2333 wants to merge 1 commit into from
Closed

Fixed cover removal not syncing render state to clients #4937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/gregtechceu/gtceu/api/sync_system/SyncDataHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ private static Tag serializeField(HolderLookup.Provider registries, ISyncManaged
boolean writeClientFields, boolean fullSync) {
Object currentValue = field.handle.get(holder);

if (!field.isSyncManaged && currentValue == null) {
if (currentValue == null) {
var nullCompound = new CompoundTag();
nullCompound.putBoolean("null", true);
return nullCompound;
Expand Down
7 changes: 6 additions & 1 deletion ...m/gregtechceu/gtceu/api/sync_system/data_transformers/gtceu/CoverBehaviorTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,18 @@ public Tag serializeNBT(@Nullable CoverBehavior value,
if (value != null) {
return serialize(value, context.isClientSync(), context.lookup());
}
return new CompoundTag();
var nullTag = new CompoundTag();
nullTag.putBoolean("null", true);
return nullTag;
}

@Override
public @Nullable CoverBehavior deserializeNBT(Tag tag,
CoverBehaviorTransformer.TransformerContext<CoverBehavior> context) {
var compoundTag = ValueTransformer.assertTagType(CompoundTag.class, tag, context);
if (compoundTag.getBoolean("null")) {
return null;
}
if (context.holder() instanceof ICoverable coverable) {
return deserialize(compoundTag, coverable, context.currentValue(), context.isClientSync(),
context.lookup());
Expand Down
Loading