fix cover sync not marking null correctly#4939
Merged
Merged
Conversation
gustovafing
added
type: bugfix
1 task
jurrejelle
requested changes
Jun 17, 2026
Comment on lines
22
to
26
| if (value != null) { | ||
| return serialize(value, context.isClientSync(), context.isClientFullSyncUpdate()); | ||
| } | ||
| return new CompoundTag(); | ||
|
|
||
| var nullTag = new CompoundTag(); | ||
| nullTag.putBoolean("null", true); | ||
| return nullTag; | ||
| } |
Contributor
There was a problem hiding this comment.
can you invert this?
if value == null: {return null}
return the normal path
reads more logical to me
Comment on lines
+35
to
+37
| if (compoundTag.getBoolean("null")) { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
will this return false if the value isnt present?
Member
Author
There was a problem hiding this comment.
yeah it will, getBoolean defaults to false
Contributor
There was a problem hiding this comment.
could be maybe cleaner to do sth like if(compoundTag.hasBoolean("null") && compoundTag.getBoolean("null") == true) but that's up to you
Member
Author
There was a problem hiding this comment.
I think its fine as is
jurrejelle
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fix cover sync not marking null correctly.
based on #4937