[Feature] Add "after first hit" blocking mode#34
[Feature] Add "after first hit" blocking mode#34deeebug wants to merge 1 commit intoGrouflon:devfrom
Conversation
|
Hey, I finally got the time to test your branch, thanks again for contributing :). |
|
Well, I intended this mode to be where you could test true combo strings. First hit would be let in and anything following that shouldn't work until 90 frames. Of course, if it's a true combo string the consecutive hits would work, otherwise anything will be blocked. Hence, "after first hit". By the way, didn't notice that you had an issue up for a block mode with a similar name until a PR was sent. But, isn't this what you wrote in that issue? Or maybe it's not working that way, somehow? |
|
Hello! :D I have tested the feature and works fine, but I think this code could be more clear and DRY. Is this PR going to be merged? I also have a woking version that can be used :D |
Feel free to change or request anything for the merge.