Enhance settings schema to provide autocompletion, color picker#534
Open
baincd wants to merge 1 commit into
Open
Enhance settings schema to provide autocompletion, color picker#534baincd wants to merge 1 commit into
baincd wants to merge 1 commit into
Conversation
Owner
|
Hi - I am already in the process of doing this. I'll have a look at your changes too. |
|
Related to issue #512 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be great to add JSON schema to the more complex settings. Doing this will provide autocompletion, validation, default values, example or enum values, and color pickers for colors. Since these settings cannot be edited through the settings UI, adding this additional metadata is extremely helpful. It allows users to be able to modify settings quickly in settings.json without having to lookup or refer to the documentation.
Note: for the icon property examples, the codicon example in the autocompletion shows the actual icon rather than the value. I could not find a workaround to that.