Skip to content

Enhance settings schema to provide autocompletion, color picker#534

Open
baincd wants to merge 1 commit into
Gruntfuggly:masterfrom
baincd:add-settings-schema
Open

Enhance settings schema to provide autocompletion, color picker#534
baincd wants to merge 1 commit into
Gruntfuggly:masterfrom
baincd:add-settings-schema

Conversation

@baincd
Copy link
Copy Markdown
Contributor

@baincd baincd commented Jul 16, 2021

I think it would be great to add JSON schema to the more complex settings. Doing this will provide autocompletion, validation, default values, example or enum values, and color pickers for colors. Since these settings cannot be edited through the settings UI, adding this additional metadata is extremely helpful. It allows users to be able to modify settings quickly in settings.json without having to lookup or refer to the documentation.

Peek 2021-07-15 22-09

  • Descriptions are based on the text in the README.
  • Examples and enums come either from the README or from documentation for the CSS style (w3schools and/or MDN)

Note: for the icon property examples, the codicon example in the autocompletion shows the actual icon rather than the value. I could not find a workaround to that.

Peek 2021-07-15 22-15

@Gruntfuggly
Copy link
Copy Markdown
Owner

Hi - I am already in the process of doing this. I'll have a look at your changes too.

@depascalis
Copy link
Copy Markdown

Related to issue #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants