-
Notifications
You must be signed in to change notification settings - Fork 85
Allow longer duration KI light and randomization #1815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e722e20 to
53f8b1c
Compare
Allows longer duration KI Light and randomizing the time for puzzles
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
bfa4261 to
5e7ba4b
Compare
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
|
Okay, I think I WAS right about 3 now being a valid value... This will require a small PRP change, since the var used by "dsntKILightMachine.py" is a shared var with "xAgeSDLIntShowHide.py" which determines what objects will be enabled with each var state. Since it only went to 2 before, there were only Show/Hide instructions for 1 and 2. State 0 is off. State 1 is the broken KI machine, with weird colored blinking light and sparks that fall out of the machine. State 2 is the fixed machine which just gently strobes a purple color and has no sparks. Assuming we want state 3 to have the visual appearance of state 2, with the only difference being the random KI light time, then the Python file mod for show/hide-ing needs to be edited to have a string of "2,3" and not just "2". Otherwise it will just look entirely turned off at state 3. Luckily this change is pretty easy in the PRP, which I will do for my TreasureBookShaftEffects page. Even though I don't think we really intended for the rest area KI machine to be a set-to-random one, I still want to cover that new var number with it since it still feels weird to have a now available var not display correctly for any of the KI machines using the code, including the original one. Plus you never know what people will want to test, have on their shard, or even in their bot age. We will also need to make sure the click region itself is turned on for all 1,2,3 once we get to fixing the interactiveness to actual get the light. |
|
I'm having trouble following your comment, @EhrenCG, so - correct me if I'm wrong - we also need to adjust a PythonFileMod in Descent so that the new state 3 matches up visually with a functioning KI machine? |
Allows longer duration KI Light and randomizing the time for puzzles
Python File Mod #5 is an Integer that sets the duration of the light when unrepaired, default of 5 seconds
Python File Mod #6 is an Integer that sets the duration of the light when repaired, default of 60 seconds
byteKILightFunc now has a third option for random light time between the short and long time