Skip to content

Conversation

@Lunanne
Copy link
Member

@Lunanne Lunanne commented Oct 28, 2018

Includes the addition of GLM & GLEW. Didn't realize Deledrius was also working on that so it's probably best to wait with merging until after.

Copy link
Member

@Deledrius Deledrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing this to work from master, it compiles and runs, but the window only flashes briefly: the program exits through the "Failed to initialize GLEW" error path.

@Deledrius Deledrius changed the title Upgrade to OpenGl4 Upgrade to OpenGL4 Oct 28, 2018
@Deledrius
Copy link
Member

Deledrius commented Oct 28, 2018

Upon further debugging, the GLEW error string returned is "Missing GL version". If I change the SDL_GL_CONTEXT_MAJOR_VERSION to 3 rather than 4, I finally receive a rendered screen containing the credits.

Looks like this is caused by a lack of support on my system for OGL 4.3, so I can't test the debug portion here.

Copy link
Member

@zrax zrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After doing some research, I found that SDL2's bundled cmake modules are very different depending on whether it was built with cmake or autotools. I feel like including a full FindSDL2.cmake is overkill for fixing this, so I may try to create a simpler solution to handle both versions in a separate Pull Request.

@Lunanne
Copy link
Member Author

Lunanne commented Nov 14, 2018

@zrax is there a name for the specific indent style that you want? I'm having trouble configuring Clion to format it correctly and I would like to save us some time in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants