Open
Conversation
Refactored Spawn Handler into HDCoreLib Commands
since HDBulletLib rounds are all defaulted to "never", they will now have to be defaulted to 0.0 instead of -1. Update their sliders to use a standard slider instead of the ScaleSlider
Forgot this one
Reusable Ammoboxes can worry about themselves, although this will mean it will need to be loaded after BOTH HDBulletLib AND Merchant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally, after many months of active development, we've finally had our Initial Release of HDCoreLib! With that beast finally having been officially made public, I think it's finally time to begin making Pull Requests for various addons whom which I used during development to learn how they are all being used, where common coding patterns arose and thus could be refactored, etc.
Take this PR not as a sign of requirement to merge, nor a sign of necessity to implement yourself, but rather to show my work, provide transparency into the changes used, and if integration was desired but felt daunting, a starting point into doing so. If anything looks incorrect or needs some refinement please let me know!
Looks like there may have been some new content added since the branch was created, so we may need to sync up those changes before this is fully considered done, but otherwise this should be ready for review!