Add support for eiger-stream-v2 and selecting panel buffers by name #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds support for changing the threshold settings for Eiger stream v2 files. The application automatically detects if eiger-stream-v2 files are loaded. If they are, new options appear in the raw view settings that allow users to switch between the different threshold settings. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This corresponds to the `eiger-stream-v2` hexrd PR branch which adds support for setting panel buffers by known names. Users can specify the panel buffer by name in the panel buffer dialog, and all logic now supports panel buffers that were specified by name. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
force-pushed
the
eiger-stream-v2
branch
from
b0f5bbd to
92f9975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an eiger-stream-v2 file is loaded, new options appear in the raw view to select which images to view:
Threshold 1viewsthreshold_1,Threshold 2viewsthreshold_2, andDifferenceloads the images using the following expression:These settings in the raw view will affect the images in the entire program.
This PR also adds support for selecting panel buffers by name:
This will be very helpful for Eiger, since the panel buffer is well-known and will not change. It also adds support for the
chess-eiger-stream-v2panel buffer.Depends on: HEXRD/hexrd#860
Fixes: #1921